Merged
Conversation
Collaborator
|
Probably want to wait for Ruff 0.11 that was just released |
knope-bot
bot
force-pushed
the
knope/release
branch
3 times, most recently
from
811e9a3 to
e6f78de
Compare
dbanty
approved these changes
Mar 15, 2025
knope-bot
bot
force-pushed
the
knope/release
branch
2 times, most recently
from
f54fc69 to
e6a597f
Compare
knope-bot
bot
force-pushed
the
knope/release
branch
from
360ace9 to
5da0fd0
Compare
micha91
pushed a commit
to micha91/openapi-python-client
that referenced
this pull request
May 13, 2025
> [!IMPORTANT] > Merging this pull request will create this release ## Features - allow Ruff to 0.10 (openapi-generators#1220) - allow Ruff 0.11 (openapi-generators#1222) - Allow any `Mapping` in generated `from_dict` functions (openapi-generators#1211) ## Fixes ### Always parse `$ref` as a reference If additional attributes were included with a `$ref` (for example `title` or `description`), the property could be interpreted as a new type instead of a reference, usually resulting in `Any` in the generated code. Now, any sibling properties to `$ref` will properly be ignored, as per the OpenAPI specification. Thanks @nkrishnaswami! Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Merging this pull request will create this release
Features
Mappingin generatedfrom_dictfunctions (feat: Allow anyMappingin generatedfrom_dictfunctions #1211)Fixes
Always parse
$refas a referenceIf additional attributes were included with a
$ref(for exampletitleordescription), the property could beinterpreted as a new type instead of a reference, usually resulting in
Anyin the generated code.Now, any sibling properties to
$refwill properly be ignored, as per the OpenAPI specification.Thanks @nkrishnaswami!